Replace exit(status); by return status; in triangle.c
- Tracker changed from Bug to Feature
- Status changed from New to Resolved
- Assignee set to Paul
- Target version set to Candidate for next bugfix release
THink I did this a few days ago but did not notice the issue being added.
No, I mean really replace exit() by return in triangle.c/triexit() function.
It will not solve anything at the triangle level but it will prevent the blow up of external API that use it.
I know, but the cause was pscontour calling triangle with no data. I now prevent that in pscontour and triangulate, so there really should not be any case where it will call exit, no?
As we know now no, but any memory error may trigger the bomb so safer not leave it armed.
I would if it was our code, but rather not make any edit to 3rd party code. Can't we wait to see if there really are any problems? The one Rick found was ours basically.
Well, we already fixed that 64 bits problem that triangle has due to its age and would crash MSVC builds on Windows 7 and above.
Also available in: Atom